Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced string storage using tokens #15593

Merged

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Oct 17, 2019

This PR extends the menu system with methods to insert an integer (or other info) into strings as they are printed to the screen, eliminating the need to define redundant strings which only differ by an index number.

On hold…. This can be rebased for further development after #15760 is merged.

@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch 8 times, most recently from de5a040 to 7173891 Compare October 19, 2019 17:40
@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch 2 times, most recently from ba1d5df to 26a2065 Compare October 24, 2019 20:51
@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch 8 times, most recently from 42176b8 to a6d9bb4 Compare November 2, 2019 11:32
@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch 7 times, most recently from 1d57c4b to bd88f51 Compare November 7, 2019 08:11
@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch 3 times, most recently from a6ae45b to f9a6cc0 Compare November 8, 2019 09:52
@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch 4 times, most recently from 73392d0 to 0c5cd76 Compare November 8, 2019 21:59
@thinkyhead thinkyhead force-pushed the bf2_indexed_menu_items_PR branch from 0c5cd76 to d88a44c Compare November 14, 2019 08:39
@thinkyhead thinkyhead merged commit 27cb4db into MarlinFirmware:bugfix-2.0.x Nov 15, 2019
@thinkyhead thinkyhead deleted the bf2_indexed_menu_items_PR branch November 15, 2019 02:30
philippniethammer pushed a commit to philippniethammer/Marlin that referenced this pull request Dec 21, 2019
christran206 pushed a commit to christran206/Marlin2.0-SKR-Mini-E3-1.2 that referenced this pull request Dec 30, 2019
robbycandra added a commit to robbycandra/Marlin that referenced this pull request Apr 5, 2020
# Conflicts:
#	Marlin/src/lcd/menu/menu.h
#	Marlin/src/lcd/menu/menu_advanced.cpp
#	Marlin/src/lcd/menu/menu_filament.cpp
#	Marlin/src/lcd/menu/menu_media.cpp
#	Marlin/src/lcd/menu/menu_motion.cpp
#	Marlin/src/lcd/menu/menu_temperature.cpp
#	Marlin/src/lcd/ultralcd.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant